Add Wordlist::get_words_by_prefix for auto-completions and validation #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wigy-opensource-developer
force-pushed
the
add_get_words_by_prefix
branch
from
09d659b to
82c968b
Compare
maciejhirsz
requested changes
Mar 26, 2020
|
@wigy-opensource-developer on the first point, I think doing |
wigy-opensource-developer
force-pushed
the
add_get_words_by_prefix
branch
from
82c968b to
d46fe5a
Compare
I did not want to extend the PR with this. Just changing the method to pub fn get_word(&self, bits: impl Into<Bits11>) -> &'static str {
self.inner[bits.into().bits() as usize]
}causes compilation issues in 3 callers, because the parameter type at the call site will be ambiguous. Because that is unrelated to what this PR is about, I just left it unchanged. |
maciejhirsz
approved these changes
Mar 27, 2020
|
Published as 0.7.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wordlist.get_word(&self, bits: Bits11)is exported from the crate, but theBits11type is not, therefore it is unusable for the UI to give auto-completion or word-by-word validation. I have added a method to query all words that start with a prefix so the UI can decide whether they want to call it once with an empty string and provide auto-completion on their side, or they want to call this method each time the user settles with typing to provide valid continuations.Thought about starting with a slice::binary_search, but I doubt we should optimize UI code without measuring a problem there.